Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default User Credentials #322

Closed
Seokyun-Ha opened this issue Jun 8, 2023 · 0 comments
Closed

Default User Credentials #322

Seokyun-Ha opened this issue Jun 8, 2023 · 0 comments

Comments

@Seokyun-Ha
Copy link
Contributor

Seokyun-Ha commented Jun 8, 2023

Is your feature request related to a problem? Please describe.
On the Dathaub Official documenet, it suggests the create default user credential by hand.
https://datahubproject.io/docs/authentication/changing-default-credentials/

However, this manual task can be ignored and default Datahub master account's id/pw is too trivial, so Anonymouses or Attackers can easily enter the datahub frontend page.

Describe the solution you'd like
Set default user credentials directly in helm value file, without creating secret manually.

Describe alternatives you've considered
The credential can be repalced by extraEnv and lifecycle.postStart. However, it is environment variable, so it can be revealed as plaintext, and revealed when helm diff. Also, this method only support single user id/pw replacing.

  extraEnvs:
    - name: DATAHUB_MASTER_PASSWORD
      value: newpassword
  lifecycle:
    # To add a new user to datahub in JAAS config without mounting the user.props file
    postStart:
      exec:
        command: ["/bin/sh", "-c", "echo datahub:$DATAHUB_MASTER_PASSWORD > /datahub-frontend/conf/user.props"]

Additional context
https://datahubproject.io/docs/authentication/changing-default-credentials/

#321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant