Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-autoshare never triggered? #26

Closed
rvalyi opened this issue Apr 3, 2019 · 5 comments
Closed

git-autoshare never triggered? #26

rvalyi opened this issue Apr 3, 2019 · 5 comments

Comments

@rvalyi
Copy link

rvalyi commented Apr 3, 2019

Hello @sbidoul. I like both your git-aggregator and git-autoshare tools. However, git-aggregator triggers git init and git fetch but never the git clone command (see https://github.com/acsone/git-aggregator/blob/master/git_aggregator/repo.py ).
So git-autoshare will never get triggered unless you do a git clone of the repo previously before calling git-aggregator.
Woudn't there be a way to trigger git clone/git-autoshare when the repo is empty at least?
What do you think?

@sbidoul
Copy link
Member

sbidoul commented Apr 4, 2019

That needs investigation. Does not sound trivial at first glance.

Note that we don't really suffer much about this in our workflow, because git-aggregate is infrequent, comparing to git cloning of frozen references (aka pip install requirements.txt :). git-aggregate is typically done at the beginning of a development cycle to refresh base versions of unmerged PRs.

@rvalyi
Copy link
Author

rvalyi commented Apr 4, 2019

@sbidou. Yes it's also infrequent for us. Today it's just about remembering to do a git clone manually when starting a new Docky project. Eventually we do that in akretion/ak, I will check with the rest of the team and confirm if we can tackle it this way.

@sbidoul
Copy link
Member

sbidoul commented Jul 22, 2023

This was resolved in #55

@sbidoul sbidoul closed this as completed Jul 22, 2023
@rvalyi
Copy link
Author

rvalyi commented Jul 22, 2023

thanks, BTW both tools absolutely rock!

@rvalyi
Copy link
Author

rvalyi commented Jul 30, 2023

just a message to confirm my tests show it was really fixed. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants