-
Notifications
You must be signed in to change notification settings - Fork 75
Text has enhanced contrast - Passed example 7 + clarification #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For the first part (user styles, or preferences), this is essentially handled in the definition of the CSS input aspect:
See also #1654 for discussions that lead to that solution. The key point is that the rule does not care about the origin of styles. It is only the example that break in presence of user styles. So, changing the rule to require that the colours have author origin (which is easy for CSS properties since For the second point, yes, the rule passes such a case. Which, as always, doesn't imply that the SC fails (rule passes => further testing is needed). |
Thanks @Jym77 for clarifications. Everything is clear. I'm still just "concerned" about the quoted sentence:
For example, my Safari in dark mode has a white text over a black background, which is the opposite of what's written here (without changing any preference). This will be always valid regardless the technology used. |
While reviewing pull request #1904 I noticed passed example 7:
In particular
with the introduction of dark/light mode, now this might not be always true.
Moreover, in this scenario, colors might be defined by the user and they are no longer an author responsibility.
Basically, it's currently passing, but not really because the contrast ratio is always sufficient.
Should we add some language somewhere better explaining this scenario?
Some possibilities:
One more clarification, just to be sure I've properly understood the specific rule expectations:
is it intended to say that the following example is currently passing because the highest possible contrast between the foreground color (#333 dark grey) and background color (#FFF white) is 12.63:1, even if half letter has a contrast ratio of 1.66 (#333 dark grey on #000 black)?
Thanks
The text was updated successfully, but these errors were encountered: