Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks cleanup upon Helm uninstall #2204

Open
KernelPryanic opened this issue Jan 24, 2023 · 1 comment
Open

Webhooks cleanup upon Helm uninstall #2204

KernelPryanic opened this issue Jan 24, 2023 · 1 comment
Labels
enhancement New feature or request needs triage Requires review from the maintainers

Comments

@KernelPryanic
Copy link

What would you like added?

Cleanup of validation and mutation webhooks upon helm uninstall.

Currently it's leaving validatingwebhookconfiguration and mutatingwebhookconfiguration resources such as github-runners-validating-webhook-configuration or github-runners-mutating-webhook-configuration and in case of using and changing a custom name, these resources creates a conflict which results in failed calling webhook ... error. The workaround was documented in this issue #1558.

Why is this needed?

To make a cleanup more complete and avoid problems on changing the app name.

Additional context

Managing my infrastructure through Terraform Helm provider.

@KernelPryanic KernelPryanic added enhancement New feature or request needs triage Requires review from the maintainers labels Jan 24, 2023
@github-actions
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

1 participant