Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorecard table URLs include duplicate https:// #738

Closed
phyrog opened this issue Apr 1, 2024 · 3 comments · Fixed by #748
Closed

Scorecard table URLs include duplicate https:// #738

phyrog opened this issue Apr 1, 2024 · 3 comments · Fixed by #748
Labels
bug Something isn't working

Comments

@phyrog
Copy link

phyrog commented Apr 1, 2024

URLs in the Scorecard table contain an extra https://, which breaks the links.

I believe the issue lies here:

`<tr><td>${dependency.change.source_repository_url ? `<a href="https://${dependency.change.source_repository_url}">` : ''} ${dependency.change.ecosystem}/${dependency.change.name} ${dependency.change.source_repository_url ? `</a>` : ''}</td><td>${dependency.change.version}</td>

Example of the problem:

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 9bb56186c3b09b4f86b1c65136769dd318469633 🟢 7.2
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 810 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 8
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
Security-Policy🟢 9security policy file detected
Packaging🟢 10packaging workflow detected
SAST🟢 10SAST tool is run on all commits
Pinned-Dependencies🟢 4dependency not pinned by hash detected -- score normalized to 4
Vulnerabilities🟢 82 existing vulnerabilities detected
actions/actions/dependency-review-action 5bbc3ba 🟢 6.2
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 6found 3 unreviewed changesets out of 8 -- score normalized to 6
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
SAST🟢 10SAST tool is run on all commits
Pinned-Dependencies⚠️ 1dependency not pinned by hash detected -- score normalized to 1
Vulnerabilities🟢 100 existing vulnerabilities detected

Scanned Manifest Files

.github/workflows/dependency-review.yml
@jonjanego jonjanego added the bug Something isn't working label Apr 2, 2024
@jonjanego
Copy link
Collaborator

jonjanego commented Apr 2, 2024

Thanks @phyrog - we have a PR merged to resolve this and will cut a new release shortly.

Original report

@phyrog
Copy link
Author

phyrog commented Apr 2, 2024

Hi @jonjanego, I was under the impression that the PR had already been released in 4.2.4 (mentioned in the issue you linked).

I'm running 4.2.5 and am still experiencing this bug.

@jonjanego
Copy link
Collaborator

ah, you're totally right @phyrog my mistake. we'll take a look...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants