Do not list changed dependencies in summary #828
Merged
+55
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaurer
changed the title
hmaurer
force-pushed
the
hm/summary
branch
4 times, most recently
from
218bc59
to
056b129
Compare
jonjanego
reviewed
Sep 13, 2024
elireisman
approved these changes
Sep 13, 2024
elireisman
force-pushed
the
hm/summary
branch
from
997824f
to
05042db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #786.
Problem
Right now we list every dependency that was either added or removed in the Markdown job summary. For pull requests with large number of changes, this goes over the summary size limit, as reported in #786.
Changes in this pull request
I removed the list of changed dependencies from the job summary. They can still be found in the logs. My rationale for this change is that the list of changed dependencies is likely not what users most care about in the summary: the list of vulnerable dependencies, license infringements and such are what's key. The way we were currently listing the dependency changes in the summary was not of much value either way as we were not differentiating between added dependencies and removed dependencies, we were listing all of them (whether added or removed).
This is not the most elegant way to address this issue, but it is the most straightforward.