Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File limit right now defaults to 30 #71

Closed
davazp opened this issue May 11, 2020 · 1 comment
Closed

File limit right now defaults to 30 #71

davazp opened this issue May 11, 2020 · 1 comment

Comments

@davazp
Copy link

davazp commented May 11, 2020

I found actions/labeler is using client.pulls.listFiles which has a page size of 30 files.

This means that for bigger PRs this won't assign labels properly because it won't consider all files. I get that there must be a limit because this could be very expensive otherwise. But the failure mode is surprising.

I would suggest increasing the page size to 100 (the limit of the Github API) and check if there are more files than a page, then it should emit a warning and not assign any label at all.

Thoughts?
Thanks!

@RasmusWL
Copy link

RasmusWL commented Sep 8, 2020

Fixed by #96

@davazp davazp closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants