Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error because ANDROID_NDK_PATH / HOME contain spaces #1074

Closed
AndrewPlakhotnyi opened this issue Jun 18, 2020 · 7 comments
Closed

Error because ANDROID_NDK_PATH / HOME contain spaces #1074

AndrewPlakhotnyi opened this issue Jun 18, 2020 · 7 comments
Assignees

Comments

@AndrewPlakhotnyi
Copy link

Describe the bug
ANDROID_NDK_PATH / HOME should not contain spaces. Otherwise, the script C:\Program Files (x86)\Android\android-sdk\ndk-bundle\ndk-build.cmd gives an error

 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Here is the commit changing the previous working behaviour c1ad396

The workaround is running the C:\Program Files (x86)\Android\android-sdk\ndk-bundle\build\\ndk-build.cmd directly

@dibir-magomedsaygitov dibir-magomedsaygitov added investigate Collect additional information, like space on disk, other tool incompatibilities etc. Area: Android OS: Windows Area: C/C++ and removed needs triage labels Jun 18, 2020
@dibir-magomedsaygitov
Copy link
Contributor

dibir-magomedsaygitov commented Jun 18, 2020

Hello @AndrewPlakhotnyi,
Thank for your report. We will take a look at it.

@Darleev
Copy link
Contributor

Darleev commented Jun 18, 2020

@AndrewPlakhotnyi Hello,
Thank you for the issue reported.
We have reproduced the issue on our side and find several possible workarounds for it. You can track a current status in a pull request .
I will keep you informed.

@compnerd
Copy link

Hey @Darleev if theres a mitigation for this that can be applied individually until the next update, that would be extremely helpful.

@Darleev
Copy link
Contributor

Darleev commented Jun 21, 2020

@compnerd In order to mitigate the issue, it is possible to return the old NDK path and use it in your pipeline. Steps below should help you with it:

Azure DevOps Powershell:

$androidNDK = (Get-ChildItem -Path "C:\Microsoft\AndroidNDK64\"| Sort-Object -Property Name -Descending | Select-Object -First 1).FullName
Write-Host "##vso[task.setvariable variable=ANDROID_NDK_HOME;]$androidNDK"
Write-Host "##vso[task.setvariable variable=ANDROID_NDK_PATH;]$androidNDK"

GitHub Actions Powershell:

$androidNDK = (Get-ChildItem -Path "C:\Microsoft\AndroidNDK64\"| Sort-Object -Property Name -Descending | Select-Object -First 1).FullName
echo '::set-env name=ANDROID_NDK_HOME::$androidNDK'
echo '::set-env name=ANDROID_NDK_PATH::$androidNDK'

@Darleev Darleev added bug Something isn't working and removed investigate Collect additional information, like space on disk, other tool incompatibilities etc. labels Jun 21, 2020
@Darleev
Copy link
Contributor

Darleev commented Jun 25, 2020

Hello @AndrewPlakhotnyi ,
The PR has been merged. All changes will be available after the next image rollout.
I will keep you informed.

@Darleev Darleev added awaiting-deployment Code complete; awaiting deployment and/or deployment in progress and removed awaiting-deployment Code complete; awaiting deployment and/or deployment in progress labels Jun 25, 2020
@Darleev
Copy link
Contributor

Darleev commented Jun 25, 2020

@AndrewPlakhotnyi I'm sorry, the PR still in review state. I will let you know additionally when it will be merged.

@AlenaSviridenko
Copy link
Contributor

Since we didn't hear any other complaints about current ANDROID_NDK_HOME variable, I am going to close this issue.
Please, feel free to open a new one if anything else is needed from our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants