Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Windows-2019 support for WSLv1: clarify README on WSLv1 support / point to setup-wsl task for WSLv1 distro installation #2060

Closed
vadimkantorov opened this issue Nov 16, 2020 · 7 comments
Assignees
Labels
OS: Windows question Further information is requested

Comments

@vadimkantorov
Copy link

From https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md it is not clear whether WSLv1 or WSLv2 is enabled. Both are useful for testing builds: e.g. Perl5 fails make install step on WSLv1 Perl/perl5#18254, and cperl fails build on case-insensitive mount point on WSLv1 perl11/cperl#424)

@al-cheb
Copy link
Contributor

al-cheb commented Nov 16, 2020

Hello, @vadimkantorov
Currently, only WSL1[Microsoft-Windows-Subsystem-Linux] is available on Windows Server 2019[10.0.17763 Build 1518] without pre-installed any Linux distro.

@vadimkantorov
Copy link
Author

Maybe separate windows-latest-wslv1-ubuntu-latest-like environments would be useful to spare users installing the distro every time, but it can quickly get combinatorial

@al-cheb
Copy link
Contributor

al-cheb commented Nov 16, 2020

Maybe separate windows-latest-wslv1-ubuntu-latest-like environments would be useful to spare users installing the distro every time, but it can quickly get combinatorial

Sorry, we don't have any plans to change the current infrastructure and provide a separate image for this special case. At the moment, you have got two approaches:

  1. Install Ubuntu in runtime, using a task - https://github.com/marketplace/actions/setup-wsl
  2. Use your own preconfigured self-hosted runners

@vadimkantorov vadimkantorov changed the title Windows-2019 support for WSLv1? [feature request] Windows-2019 support for WSLv1: clarify README on WSLv1 support / point to setup-wsl task for WSLv1 distro installation Nov 16, 2020
@al-cheb
Copy link
Contributor

al-cheb commented Nov 16, 2020

@vadimkantorov , I have created a tiny #2070 PR with updated wsl version. We can't include info about the setup-wsl task into the documentation file, because we use the same image for Azure PipeLines where the task is not available.

@vadimkantorov
Copy link
Author

Thanks for this README fix! Could it also mention that no distro is installed and that needs to be handled separately?

Should I file a separate feature request for providing an official Action (official equivalent of setup-wsl) to install a WSLv1 distro?

@maxim-lobanov
Copy link
Contributor

@vadimkantorov Why do you want to have official equivalent of setup-wsl?
Unfortunately, GitHub can't provide official actions for everything but it provides actions marketplace where everyone can write own action and share it with the world. setup-wsl is good example to show how it works.
If this action suits for you purposes, I suggest continue using it.

@al-cheb
Copy link
Contributor

al-cheb commented Nov 18, 2020

I am planning close the thread. I'll let you know if there's any change related to WSL.

@al-cheb al-cheb closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Windows question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants