Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg upgrade required since pcre issue #4458

Closed
1 of 7 tasks
arsdever opened this issue Nov 10, 2021 · 6 comments
Closed
1 of 7 tasks

vcpkg upgrade required since pcre issue #4458

arsdever opened this issue Nov 10, 2021 · 6 comments
Labels
Area: C/C++ Area: Common Tools awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Windows

Comments

@arsdever
Copy link

arsdever commented Nov 10, 2021

Description

Hi guys. I'd like to ask the vcpkg upgrade on (at least) windows build machines because of the pcre package issues reported here microsoft/vcpkg#21201.

Virtual environments affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

20211102.4

Is it regression?

No response

Expected behavior

It's possible to install pcre through vcpkg

Actual behavior

It's failing to install pcre

Repro steps

Setup a job that installs pcre (in my case I install boost-test, qt5-base, and spdlog: pcre as a dependency).
https://github.com/arsdever/lcd/runs/4162600024?check_suite_focus=true

@al-cheb
Copy link
Contributor

al-cheb commented Nov 10, 2021

Hey, @arsdever
We have been starting a new image rollout with Vcpkg (build from master <70033db>) #4460. Will it work for you?

@al-cheb al-cheb added awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Windows Area: C/C++ Area: Common Tools and removed needs triage labels Nov 10, 2021
@arsdever
Copy link
Author

Hey, @arsdever We have been starting a new image rollout with Vcpkg (build from master <70033db>) #4460. Will it work for you?

Do I have any ways to check if the proposed image for the build machine will work? AKA, can I run my action on the proposed machine image?

@al-cheb
Copy link
Contributor

al-cheb commented Nov 10, 2021

Currently, you can not run on the latest image. I have checked vcpkg install --triplet x64-windows pcre and looks like it's working now:
image

@arsdever
Copy link
Author

If it works, then I'd guess I'll be good with that image. Will update on this thread if the issue is still there after the image is published.

@al-cheb
Copy link
Contributor

al-cheb commented Nov 11, 2021

@arsdever , Windows Server 2019 has been deployed with Vcpkg (build from master <70033db>).

@al-cheb al-cheb closed this as completed Nov 11, 2021
@arsdever
Copy link
Author

I have rerun my workflow and it succeeded. Thanks for taking care of the upgrade. 👍🏼 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C/C++ Area: Common Tools awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: Windows
Projects
None yet
Development

No branches or pull requests

2 participants