Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named log groups #1477

Open
umarcor opened this issue Nov 12, 2021 · 3 comments
Open

Support named log groups #1477

umarcor opened this issue Nov 12, 2021 · 3 comments
Labels
enhancement New feature or request future Feature work that we haven't prioritized

Comments

@umarcor
Copy link

umarcor commented Nov 12, 2021

Describe the enhancement

Currently, it is possible to wrap logs in collapsible groups through ::group:: and ::endgroup::. The former accepts an optional string, which is used as the title of the collapsible header. However, the endgroup does not support any additional argument. As a result, it is not possible to uniquely identify the matching start and end statements, thus, preventing nesting, hierarchical view, etc.

The implementation of this feature in other services allows using a keyword to match open and close statements.

Code Snippet

echo "::group::Title"
echo "Foo"
echo "::endgroup::"

Possible enhancement:

echo "::group::mykey::Title"
echo "Foo"
echo "::endgroup::mykey::"

Additional information

Since composite actions can include other actions (up to 10 levels of hierarchy), log groups are likely to conflict. Keywords might be implicitly used for enhancing the current UI.

Refs: #802 #1272 #1279 #1404

/cc @thboop @andreineculau @pbartolome

@ethomson
Copy link
Contributor

Thanks for the suggestion - having a hierarchy here seems like it might be useful, indeed. However, there are a lot of considerations around page rendering and performance that we would need to think through. I'm going to put this on the backlog, but this isn't something that we have planned to work on in the very near future. Thanks again!

Copy link
Contributor

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Mar 18, 2024
@Piedone
Copy link

Piedone commented Mar 18, 2024

Still interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Feature work that we haven't prioritized
Projects
None yet
Development

No branches or pull requests

3 participants