Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting TreatWarningsAsError for all projects #179

Closed
Eilon opened this issue Nov 5, 2019 · 0 comments · Fixed by #249
Closed

Consider setting TreatWarningsAsError for all projects #179

Eilon opened this issue Nov 5, 2019 · 0 comments · Fixed by #249

Comments

@Eilon
Copy link
Contributor

Eilon commented Nov 5, 2019

After a few of the currently-open PRs are merged (#174, #178), all compiler and code analyzer warnings should be fixed. It would be good to set TreatWarningsAsErrors to true for all projects to ensure that contributors are forced to fix warnings before submitting a PR.

I recommend this setting be placed in the new Directory.Builds.props file that I included in this PR: https://github.com/actions/runner/pull/173/files#diff-6483fde6c45c90fdfe98ca72eadfa651

That way the setting will automatically be shared by all projects in that folder and sub-folders. Individual projects can override that setting if they want to (but they shouldn't!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant