Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the minimum dependencies necessary to use this action with custom containers #399

Closed
kevinburke1 opened this issue Dec 6, 2019 · 9 comments · Fixed by actions/checkout#104

Comments

@kevinburke1
Copy link

It would be nice to know the minimum amount of software necessary to run this with a custom container. For example, this project requires git at at least v2.18.

I'm currently trying to debug this failure:

/usr/bin/docker exec  186a95cc5746a0d66133af0ae7ec9e161d903825e4c12bdf02f1a2fcede1fe14 sh -c "cat /etc/*release | grep ^ID"
Running JavaScript Action with default external tool: node12
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "no such file or directory": unknown

I suspect this means I need to add Node.js to the container image but I'm not sure.

@ericsciple
Copy link
Collaborator

@kevinburkemeter thanks. We're going to fallback to downloading the repo using the REST API if git isnt in the PATH.

@ericsciple
Copy link
Collaborator

will be fixed by pr actions/checkout#104

@ericsciple ericsciple self-assigned this Dec 10, 2019
@chrispat
Copy link
Member

@kevinburkemeter we automatically inject node into the container as that is a runtime concern you should not have to deal with.

@davidkarlsen
Copy link

I'm still seeing this with actions/checkout@v2 and also master.
I'm running on self-hosted runner, with a custom container:

build:
    runs-on: self-hosted
    container: maven:3-jdk-11

@ericsciple ericsciple reopened this Mar 31, 2020
@ericsciple
Copy link
Collaborator

Transferring to actions/runner

This looks related to minimum dependencies to run any javascript action.

Related to #334 ?

@ericsciple ericsciple transferred this issue from actions/checkout Mar 31, 2020
@ericsciple ericsciple removed their assignment Mar 31, 2020
@igagis
Copy link

igagis commented Jul 3, 2021

@chrispat

we automatically inject node into the container as that is a runtime concern you should not have to deal with.

is node a binary executable? What if my container is i386 or arm?

still seeing the issue:
https://github.com/cppfw/utki/runs/2980442190?check_suite_focus=true#step:4:22

@nikola-jokic
Copy link
Contributor

Hi @igagis! Is this issue still a problem on a newer runner version?

@igagis
Copy link

igagis commented Feb 2, 2022

@nikola-jokic I don't know, I'm not using official runner for self-hosted machines anymore, I'm using https://github.com/ChristopherHX/github-act-runner and also I don't use javascript-based actions in my pipelines anymore. So, I cannot check, sorry.

@nikola-jokic
Copy link
Contributor

Since this issue is related to actions/checkout, but we use this issue board to track issues with the runner, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants