Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] add support go.work file for go-version-file #284

Closed
koba1t opened this issue Nov 1, 2022 · 2 comments
Closed

[Feature request] add support go.work file for go-version-file #284

koba1t opened this issue Nov 1, 2022 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@koba1t
Copy link
Contributor

koba1t commented Nov 1, 2022

Description:
Support go workspace mode for go-version-file.
go workspace uses go.work file that summarizes packages when the repo contains multiple packages.

Justification:
If repo contains multiple go packages with many go.mod files, we can't select one go.mod file to set go-version-file.
So, that case we can use go workspace mode and create one go.work file to summarize packages.
This "Feature request" wants to select the go version from the go.work file to easy to set the go version in CI.

Are you willing to submit a PR?

@koba1t koba1t added feature request New feature or request to improve the current logic needs triage labels Nov 1, 2022
@marko-zivic-93
Copy link
Contributor

Hello @koba1t
Thank you for your feature request. We are looking into it, and will come back to you as soon as we have some information :)

@e-korolevskii
Copy link
Contributor

Hello @koba1t

We just merged this pull request, but we need to wait for the new release to use these changes.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants