-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing node-version without changing action makes merging impossible (required job pending) #1107
Comments
Hello @tommyboylab 👋 , |
Hi @tommyboylab, When you bump the Node.js version in a GitHub Action and find that a required status check from a previous action is preventing you from merging, you can resolve this issue by updating the branch protection rules to reflect the new action. Here’s what you can do:
Additionally, please ensure that you do not include node-version: 16 in your workflow file. For detailed steps on editing branch protection rules, you can refer to GitHub's documentation on configuring protected branches. This should resolve the issue and allow you to merge the PR. |
Hello @tommyboylab, We are proceeding to close this issue as we didn't hear anything from a long time and please feel free to reach us in case any clarifications/support needed to reopen this issue. Thank you. |
Description:
After bumping the node-version used by an action, I find that I'm unable to merge a PR with the changes as the previous action is marked as required but never finished (since it no longer exists)
Action version:
v4
Platform:
Runner type:
Tools version:
Node-version 16 -> 18,
Bun 1.1.18+5a0b93523
Repro steps:
Expected behavior:
Bumping node version should not create duplicate jobs, should replace the old jobs.
Actual behavior:
Bumping node version duplicates the jobs, marking old ones (which never run as they don't exist) as required so PR is unable to be merged.
The text was updated successfully, but these errors were encountered: