-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.7.0 is a breaking change #814
Comments
Hello @eddiemonge. Thank you for your report. I think it is not a breaking change because regarding to the thread it didn't work as expected initially because of parsing logic that is why on the post step the action was getting different value. |
Changing the default or expected value from null to string would seem to me to be breaking. One day my gh actions worked, and the next, they didn't, without my code changing. I would consider that a breaking change, since it had been that way all of 3.x |
Could you please describe your case with changing value from null to string? Do you mean post input ? Could you please attach failed build if it is possible ? |
Hello @eddiemonge. Could you please try to use changes changes from the main branch ? |
Hello @eddiemonge. The new version of setup-node was released. For now I'm going to close the issue. |
Version 3.7.0 is a breaking change. Does this project follow semver? If not, I'll pin my project to use 3.6.0 until 3.7.0 is fixed (see #797 (comment)).
If this was not meant to be a breaking change, I suggest unpublishing version 3.7.0 or doing a patch version to revert functionality
The text was updated successfully, but these errors were encountered: