Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Abandoned repo? #42

Closed
veganstraightedge opened this issue Dec 27, 2019 · 9 comments
Closed

Abandoned repo? #42

veganstraightedge opened this issue Dec 27, 2019 · 9 comments
Labels
question Further information is requested

Comments

@veganstraightedge
Copy link

I really like this action. I love how simple it makes adding a Ruby to a workflow. I would really love to continue to use it instead of Dockerizing all of the things. However, it seems like this repo is abandoned and not actively maintained.

If it is abandoned, would it possible for GitHub to find some other folx to own it, please? Having first party, top level support for Ruby in Actions feels really important to me.

❤️

@ioquatix
Copy link

@dmarcey who is maintaining this gem? Is GitHub willing to sponsor me to maintain it?

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Dec 28, 2019

@ioquatix

Not sure if the issue is this action, or the fact that MSFT/GitHub aren't interested in timely updates to the images.

So, along with this repo (or a new one owned by Ruby?), maybe somewhere Ruby packages can be created to allow their use on Actions?

I've already got an action that installs MinGW Ruby 2.3 thru master from available packages...

@ioquatix
Copy link

This should be the official action repo, and we should be enhancing it. It would make sense for people close to Ruby to be maintaining it. Can you share your actions repo?

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Dec 28, 2019

https://github.com/MSP-Greg/actions-ruby

There is one change I've been meaning to make to it. Moving it somewhere else (Ruby?) would be fine. Then everyone could create Ruby builds that would work with platforms/OS's other than windows.

Given that most of the STDLIB is now 'gemified', Ruby having their own repos to help with CI certainly makes sense.

@MSP-Greg
Copy link
Contributor

I'm wondering whether a possible solution is to create an action that wraps RVM?

One reason to wrap it with an action is the 'ENV' isolation that exists with Actions steps...

@ioquatix
Copy link

ioquatix commented Dec 29, 2019

I discussed this with @envato and I hope it's okay to mention some of the ideas they had here.

One idea was to use Heroku buildpacks, or at least provide that as an option.

I'm not against using RVM, but I wonder if we should just compile from source or use something really simple like ruby-build or ruby-install. Ideally we want to support JRuby and TruffleRuby as easily as possible.

@bryanmacfarlane
Copy link
Member

It is not abandoned :) . It was hectic with GA and now holidays. I'll get some focus on it. Thanks for the bump.

@solnic
Copy link

solnic commented Jan 2, 2020

@ioquatix I'm not against using RVM, but I wonder if we should just compile from source or use something really simple like ruby-build or ruby-install. Ideally we want to support JRuby and TruffleRuby as easily as possible.

Can we please please please try to use ruby-install and switch to rvm only when there is really a serious need for it?

I'm more than happy to help with this repo btw. We've adopted GH Actions in all dry-rb repos and we're in the process of doing the same thing in rom-rb and having to special-case JRuby in our CI setups was somewhat problematic and made things more complex. We would also love to start running our spec suites against TruffleRuby but as long as it's not trivial to set it up, we won't do it.

ps. sorry for commenting on a closed issue, I was late to the party ;)

@eregon
Copy link
Contributor

eregon commented Jan 2, 2020

This discussion in general is continuing in #44

I'm more than happy to help with this repo btw. We've adopted GH Actions in all dry-rb repos and we're in the process of doing the same thing in rom-rb and having to special-case JRuby in our CI setups was somewhat problematic and made things more complex. We would also love to start running our spec suites against TruffleRuby but as long as it's not trivial to set it up, we won't do it.

See #28 for TruffleRuby support (but not yet reviewed).

#44 (comment) is a prototype of an action that makes it easy to use MRI, JRuby and TruffleRuby on Linux and macOS (and BTW it uses Rubies built by ruby-install).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants