-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue closed close period
days after reopen
#351
Comments
@TheOneRing I added a reproduction in the tests and basically the culprit here is that the issue was reopened without removing the stale label. I thought that only the updateAt/last comment was a requirement to know if it's stale or not but in fact having a stale label influence the action and has a better priority. On the other hand, it can be convenient to have eventually a feature which remove the stale label for you when the issue/PR is reopen but in that case opening a new issue for that would be better. |
Yes but I would expect a message that #xxx is going to be closed in 7 days because of reasons :) |
@TheOneRing IMO the best option to solve this is to remove the stale label after reopening. |
Option two sounds handy, as this behavior should also cause a message on manually labeled issue? |
@TheOneRing yes, I think the only missing piece is the comment when you manually label as stale. |
The issue owncloud/client#8365 was closed automatically 8 days after it was reopened.
Without any previous stale message
The text was updated successfully, but these errors were encountered: