Issue closed close period days after reopen

[TheOneRing]

The issue owncloud/client#8365 was closed automatically 8 days after it was reopened.
Without any previous stale message

[C0ZEN]

@TheOneRing I added a reproduction in the tests and basically the culprit here is that the issue was reopened without removing the stale label.
I was not aware of this and in fact I think it's awesome because it can close #188 IMO.

I thought that only the updateAt/last comment was a requirement to know if it's stale or not but in fact having a stale label influence the action and has a better priority.
What do you think?

On the other hand, it can be convenient to have eventually a feature which remove the stale label for you when the issue/PR is reopen but in that case opening a new issue for that would be better.

[TheOneRing]

Yes but I would expect a message that #xxx is going to be closed in 7 days because of reasons :)

[C0ZEN]

@TheOneRing IMO the best option to solve this is to remove the stale label after reopening.
Basically reopening means that it's a keeper so it's kinda opposite to letting it be stale.
It could be made with an option and if disabled instead send once again the message saying that it will be closed in x days.
Is this ok for you?

[TheOneRing]

Option two sounds handy, as this behavior should also cause a message on manually labeled issue?

[C0ZEN]

@TheOneRing yes, I think the only missing piece is the comment when you manually label as stale.
And I also think also that the best solution would be to remove the stale label once closed.