Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the documentation and the options between issues and PRs #493

Closed
C0ZEN opened this issue Jun 7, 2021 · 11 comments · Fixed by #586
Closed

Split the documentation and the options between issues and PRs #493

C0ZEN opened this issue Jun 7, 2021 · 11 comments · Fixed by #586
Labels
enhancement New feature or request

Comments

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 7, 2021

The problem

From #473 (comment).

We have too many options and few options are only available for PRs.
The documentation, as well as the code, would be cleaner if we consider both workflows as unique instead of trying to mix them.

The solution

Split everything in half inside the documentation.
Remove every options that alter both issues and PRs (shortcuts).

I will provide a PR for this.

@C0ZEN C0ZEN added the enhancement New feature or request label Jun 7, 2021
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jun 9, 2021

@luketomlinson once the current PR are merged, I can work on this one FYI.
Huge PR incoming 👀

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jul 10, 2021
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jul 10, 2021

up

@github-actions github-actions bot removed the Stale label Jul 11, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Aug 10, 2021
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Aug 10, 2021

up

@ciaransweet
Copy link

@C0ZEN I see you on a lot of the issues and this one is slightly related to a use-case I have - I'm looking through the documentation and I can't figure out if I can just disable making PRs stale completely?

I'm only interested in Issues, we don't have a unmanageable amount of PRs to worry about...

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Aug 10, 2021

@CiaranEvans you can set https://github.com/actions/stale#days-before-pr-stale and https://github.com/actions/stale#days-before-pr-close to -1.

@ciaransweet
Copy link

@C0ZEN Ah awesome, thanks!

@github-actions github-actions bot removed the Stale label Aug 11, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 11, 2021
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Sep 11, 2021

up

@github-actions github-actions bot removed the Stale label Sep 12, 2021
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Oct 8, 2021

I will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants