Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache upload does not handle 429 error #1589

Open
dsame opened this issue Nov 30, 2023 · 4 comments
Open

Cache upload does not handle 429 error #1589

dsame opened this issue Nov 30, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@dsame
Copy link

dsame commented Nov 30, 2023

Describe the bug
Occasionally, caching actions fail at Post step:

Post job cleanup.
/usr/bin/tar --posix --use-compress-program zstdmt -cf cache.tzst --exclude cache.tzst -P -C /runner/_work/beam/beam --files-from manifest.txt
Warning: Failed to save: Cache service responded with 429 during upload chunk.
/runner/_work/_actions/actions/setup-java/v3.8.0/dist/cleanup/index.js:401
                        throw new Error(`Cache upload failed because file read failed with ${error.message}`);
                        ^

Error: Cache upload failed because file read failed with EBADF: bad file descriptor, read
    at ReadStream.<anonymous> (/runner/_work/_actions/actions/setup-java/v3.8.0/dist/cleanup/index.js:401:31)
    at ReadStream.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at errorOrDestroy (node:internal/streams/destroy:220:7)
    at node:internal/fs/streams:262:9
    at FSReqCallback.wrapper [as oncomplete] (node:fs:671:5)

Example run: https://github.com/apache/beam/actions/runs/6307333506/job/17123805683?pr=28079

A solution could be ignore this transient error similar to here: coursier/cache-action#131

Additional context
original issue: actions/setup-java#543

@paulschreiber
Copy link

We hit this many times tonight. Example.

@sidey79
Copy link

sidey79 commented Apr 21, 2024

I have the same issue downloading from the cache fails often because Ratelimit exceeded:

As noted in https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#exceeding-the-rate-limit
The delay needed for a retry can bei read in the http response.

@trajan0x
Copy link

Also seeing this issue.

Example workflow from open source repo (this was on synapsecns/sanguine#2739 )
image

@dan-blanchard
Copy link

Seeing this issue regularly today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants