Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listTar (enabled by debug mode) becomes very verbose in case of large repos like a node.js monorepo #729

Closed
sgronblo opened this issue Mar 3, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@sgronblo
Copy link

sgronblo commented Mar 3, 2021

If your issue is relevant to this repository, please include the information below:

Describe the bug
Maybe could be considered a feature request as well. As stated in the title, a recent change to @actions/cache added a call to listTar in case core.isDebug() is true. This change can be seen here: bfdba95#diff-34e72845d1658a8a9b9fdfe6b5b9261952e7f0496a0a3fcec87dae722718a64aR171

My current project uses Cypress with a monorepo and we have enabled debug for seeing debug output from other actions such as @cypress-io/github-action. However, the cypress action additionally tries to cache your npm/yarn folder. In this case you will see the contents of all the files in all your node_modules as part of your test output. In our case this is close to 100k of additional lines that slow down the GH action result viewer. It would be nice if the call to listTar was controllable through another flag in addition to core.isDebug so we could avoid this.

To Reproduce
Steps to reproduce the behavior:

  1. Create a node.js monorepo and add a large amount of node_modules dependencies
  2. Add cypress tests
  3. Setup the @cypress-io/github-action plugin for your repo
  4. Enable debugging by creating a secret called ACTIONS_STEP_DEBUG with the value true
  5. Trigger a test run
  6. Check the output in GH

Expected behavior
Every file in node_modules should not be shown.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: any
  • Browser: any
  • Version: @actions/cache@1.0.6

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser any
  • Version any

Additional context
Add any other context about the problem here.

@sgronblo sgronblo added the bug Something isn't working label Mar 3, 2021
@sgronblo
Copy link
Author

sgronblo commented Mar 3, 2021

To be more specific, the cypress action is not caching your node_modules folder, it caches your yarn/npm cache folder.

@thboop thboop added enhancement New feature or request and removed bug Something isn't working labels Apr 23, 2021
@thboop
Copy link
Collaborator

thboop commented Apr 23, 2021

Hey @sgronblo , I understand the pain here, but we are unlikely to add individual outputting debug tuning on functions in the toolkit in the near future.

@bahmutov
Copy link

@sgronblo I am switching Cypress GH Action to use debug module here cypress-io/github-action#379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants