Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will v3 work with Rails 8? #8627

Closed
geoffharcourt opened this issue Feb 12, 2025 · 2 comments
Closed

Will v3 work with Rails 8? #8627

geoffharcourt opened this issue Feb 12, 2025 · 2 comments

Comments

@geoffharcourt
Copy link

Testing out an upgrade to Rails 8, and seeing that parameters designated in permit_params are not being marked as permitted. Is this going to be resolved in the v3 series, or will it be a requirement to upgrade to v4 to use Rails 8?

@javierjulio
Copy link
Member

ActiveAdmin v3 does work with Rails 8 as part of our test suite in the 3-0-stable branch. Please submit a reproduction which you could probably do with our bug report template script. Thank you.

@geoffharcourt
Copy link
Author

This is embarrassing, but we figured out that the reason we were seeing failures in Rails 8 was that in some cases we were passing an array of symbols into a permit_params declaration instead of a series of symbol arguments. In Rails 7 this would still work, but as of Rails 8 this causes the params to not be registered correctly as permitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants