All void elements should be self-closing #39
Conversation
|
Noticed #26 after submitting this, which is pretty much the same issue. So I've updated the PR to make all void elements self-closing. The list of void elements was taken from here: |
| expect(arbre { | ||
| br | ||
| }.to_s).to eq("<br/>\n") | ||
| (Arbre::HTML::Tag::SELF_CLOSING_ELEMENTS).each do |tag| |
|
You don't need to create a new PR again. You can simply force push to your |
|
Updated. I made a new PR for the commit changes so that the original comments from the previous PR were preserved. I wasn't aware that GitHub preserves outdated diffs though. |
|
Thats not necessary, github shows the comments as outdated and link them to the old commit (see above). So there is now reason to create a new PR |
All void elements should be self-closing
|
Yeah, I wasn't aware of that. Thanks. |
|
I have copied to PR description and your first comment from #35 to here for a better documentation |
|
Thanks ! |
According to the HTML5 specification hr elements should not have an end tag.
http://www.w3.org/TR/html5/grouping-content.html#the-hr-element