Tag option for sets the attribute when value is a string or symbol
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,10 @@ def build(*args) | |||
| attributes = extract_arguments(args) | |||
| self.content = args.first if args.first | |||
|
|
|||
| set_for_attribute(attributes.delete(:for)) | |||
| for_value = attributes[:for] | |||
| unless for_value.kind_of?(String) || for_value.kind_of?(Symbol) | |||
There was a problem hiding this comment.
Prefer Object#is_a? over Object#kind_of?.
…ctiveadmin#18] We didn't change the option to avoid a breaking change. fixes activeadmin#18
|
It kinda makes the |
|
I would merge this, but I'm not really sure I understand the existing behavior. Also the test suite appears to be failing (but it doesn't seem to be caused by this PR). |
|
IIRC, when you add |
|
I know about this problem, this is not a nice way but if we support the Rails |
timoschilling
added a commit
that referenced
this pull request
Feb 14, 2016
Tag option `for` sets the attribute when value is a string or symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't change the option to avoid a breaking change. If changing the usage of for should change completely, a deprecation warning can easily be shown. This gets labels working fine at least.
fixes #18