Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about braintree blue refund implementation #3399

Open
daisy1754 opened this issue Oct 17, 2019 · 4 comments
Open

Question about braintree blue refund implementation #3399

daisy1754 opened this issue Oct 17, 2019 · 4 comments

Comments

@daisy1754
Copy link

daisy1754 commented Oct 17, 2019

Currently braintree blue refund is implemented in following way:

  1. try refund
  2. it it fails, try void
    response = response_from_result(@braintree_gateway.transaction.refund(transaction_id, money))

Is there any reason library is not fetching the transaction status and then do either refund or void? Current implementation is causing error response and seems a bit weird.

I'm happy to send a pull request to change behaviour but wanted to check if this is intentional. [EDIT: I no longer remember about this, so probably cannot send PR by myself]

@martinstreicher
Copy link

@daisy1754 What field in the Braintree Blue purchase transaction response represents the transaction_id to be used in the refund? Is it the network_transaction_id field found in the transaction response?

@daisy1754
Copy link
Author

@martinstreicher quite honestly I don't remember

@martinstreicher
Copy link

No worries. I found it. It's the authorization field in the response.

@curiousepic
Copy link
Contributor

Marking this "of interest" before a cleanup of stale issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants