Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to SELECT_DATA from Vault for Sage Gateway? (Passing in store GUID) #3659

Open
benparsell opened this issue Jun 9, 2020 · 1 comment
Labels

Comments

@benparsell
Copy link

Hi!

I'm running into an issue where after running a store operation and holding onto the GUID from the sagepayments API and trying to authorize, my application passes in the GUID token as a string under the credit_card parameter for the add_credit_card method where it expects that parameter to be a full CC object.

At what point would this class run a SELECT_DATA operation from the sagepayments API to pull down CC data from the vault? Is that an expectation of the user's application and then passing a full credit_card object to this class (that seems like a potential security concern)? Would it make sense for me to decorate the add_credit_card method to run my own SELECT_DATA operation if I know that the credit_card parameter is a string?

@benparsell benparsell changed the title Ability to SELECT_DATA from Vault? (Passing in store GUID) Ability to SELECT_DATA from Vault for Sage Gateway? (Passing in store GUID) Jun 9, 2020
Copy link

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

@github-actions github-actions bot added the Stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant