header field value cannot include CR/LF with Stripe

[wsmoak]

We recently started seeing "header field value cannot include CR/LF" when attempting to use Stripe.

This is the problematic line:

active_merchant/lib/active_merchant/billing/gateways/stripe.rb

Line 616 in 8b5d2ac

'Authorization' => 'Basic ' + Base64.encode64(key.to_s + ':').strip,

Apparently Stripe has started issuing secret keys (access tokens) that are much longer, and the plain encode64 method will insert newlines in long strings.

The fix is to switch to the strict_encode64 method, which does not.

This article helped us find the problem:
https://stackoverflow.com/questions/2620975/strange-n-in-base64-encoded-string-in-ruby

[nfriend21]

We just ran into this problem as well.

[fred-stripe]

A better solution might would be to use Bearer authentication, which is supported by the Stripe API as well.

This is the problematic line:

active_merchant/lib/active_merchant/billing/gateways/stripe.rb

Line 616 in 8b5d2ac

'Authorization' => 'Basic ' + Base64.encode64(key.to_s + ':').strip,

Changing this line to the following would repair the error and not require string replacement / newline stripping on the base64 output:

'Authorization' => 'Bearer ' + key.to_s,

[danwetherald]

We are now seeing this issue popup as well on newer Stripe accounts.

Any plans to push out a PR?

[danwetherald]

We recently started seeing "header field value cannot include CR/LF" when attempting to use Stripe.

This is the problematic line:

active_merchant/lib/active_merchant/billing/gateways/stripe.rb

Line 616 in 8b5d2ac

'Authorization' => 'Basic ' + Base64.encode64(key.to_s + ':').strip,

Apparently Stripe has started issuing secret keys (access tokens) that are much longer, and the plain encode64 method will insert newlines in long strings.

The fix is to switch to the strict_encode64 method, which does not.

This article helped us find the problem:
https://stackoverflow.com/questions/2620975/strange-n-in-base64-encoded-string-in-ruby

Looks like this was already committed a few weeks ago:

https://github.com/activemerchant/active_merchant/blob/master/lib/active_merchant/billing/gateways/stripe.rb#L616

[danwetherald]

After updating my ActiveMerchant gem the new stripe accounts are now working.

[github-actions]

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!