-
-
Notifications
You must be signed in to change notification settings - Fork 810
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[WIP] AC::Parameters is no longer inherited from Hash in Rails 5
Rails commit rails/rails@14a3bd5 began a series of changes that might affect many apps/gems and cause subtle bugs. This commit is a start to Ransack adapting to these changes.
- Loading branch information
Showing
2 changed files
with
10 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceafc05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone is using Rails master targeting 5.0.0.alpha right now and needs pagination that works with Ransack... without Ransack's
q
params in the pagination links turning into brokenActionController#parameters
(currently a problem with bothkaminari
andwill_paginate
):I forked and updated the
will_paginate gem here to work
. I also optimized it for Ruby 2.2 by freezing strings to reduce object allocations and memory use, and by removing legacy code for Merb and Rails 2 + 3. I'm using this in production and it's working well.In your gemfile:
ceafc05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonatack Thank you for being prepared for Rails 5 and helping out all that depend on ransack and will_paginate. Your efforts are greatly appreciated.