Skip to content

Commit e489ca7

Browse files
committed
Public method hooks for the order arrow defs
and inline the conditional.
1 parent c0dff33 commit e489ca7

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

lib/ransack/helpers/form_helper.rb

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,14 @@ def initialize(search, attribute, args, params)
9797
@default_order = @options.delete :default_order
9898
end
9999

100+
def up_arrow
101+
'▼'.freeze
102+
end
103+
104+
def down_arrow
105+
'▲'.freeze
106+
end
107+
100108
def name
101109
[ERB::Util.h(@label_text), order_indicator]
102110
.compact
@@ -190,21 +198,17 @@ def default_sort_order(attr_name)
190198

191199
def order_indicator
192200
return if @hide_indicator || no_sort_direction_specified?
193-
direction_arrow
201+
if @current_dir == 'desc'.freeze
202+
up_arrow
203+
else
204+
down_arrow
205+
end
194206
end
195207

196208
def no_sort_direction_specified?(dir = @current_dir)
197209
!['asc'.freeze, 'desc'.freeze].freeze.include?(dir)
198210
end
199211

200-
def direction_arrow
201-
if @current_dir == 'desc'.freeze
202-
'▼'.freeze
203-
else
204-
'▲'.freeze
205-
end
206-
end
207-
208212
def direction_text(dir)
209213
return 'asc'.freeze if dir == 'desc'.freeze
210214
'desc'.freeze

0 commit comments

Comments
 (0)