Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call #1146

Closed
OttilieWilliams opened this issue Aug 27, 2020 · 3 comments

Comments

@OttilieWilliams
Copy link

Steps to reproduce
Install latest Ruby 2.7.1 from Rbenv
Run Cucumber tests

Expected behavior
No errors or deprecation messages.

Actual behavior
Warnings:

/Users/example_user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/ransack-2.3.2/lib/ransack/translate.rb:86: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/example_user/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/i18n-1.8.5/lib/i18n.rb:195: warning: The called method `translate' is defined here

System configuration

Rails version:
Rails 6.0.3

Ruby version:
Ruby 2.7.1

Additional Comments:

The warnings only appear when in the gemfile ransack is set as:
gem "ransack"

The warnings stopped appearing when we changed this to:
gem "ransack", git: "https://github.com/activerecord-hackery/ransack"

We would like to continue using the gem version - perhaps this needs to be updated in line with the master branch?

@coding-chimp
Copy link

As far as I can tell this has been fixed in #1121, but there hasn't been any new release since then.

@pond
Copy link

pond commented Sep 16, 2020

👍 on this - under 2.7.x, this deprecation warning happens quite often. Good to see a PR merged in & looking forward to a new release.

@scarroll32
Copy link
Member

Closing this as fixed, @OttilieWilliams please reopen if still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants