Ransack doesn't handle attribute names including "and" / "or"

[seanlinsley]

Starting from: activeadmin/activeadmin#2669

If you have a foo_and_bar attribute on a model, this should work:

Model.search(foo_and_bar_eq: 'baz').result

My best guess is that right now the logic that allows this:

User.search(first_name_or_last_name_eq: 'baz').result

SELECT "users".* FROM "users" WHERE (("users"."first_name" = 'baz' OR "users"."last_name" = 'baz'))

Is skipping past existing attributes, and likely also skipping past existing ransackers.

[avit]

What would break if we made ransack split on __and__ / __or__ (two underscores)?

[avit]

@seanlinsley Keep in mind you can build your query from hashes, this is what ransack does when parsing it internally:

Model.search( c: [{a: ["first_name_or_last_name"], p: "eq", v: ["baz"]}] )

[seanlinsley]

I'm not actually running into this problem myself because I don't have any attributes with "and" / "or" in the name.

I only attempted a fix to force myself to better understand how Ransack works.

Is it possible to build a ransacker with the hash syntax?

[avit]

Well, you could set up a ransacker to cover the right column name; not sure how you'd want to actually use it with the hash syntax though:

ransacker :name_parts do
  arel_table[:first_name_or_last_name]
end

[seanlinsley]

This was resolved by #449

[seanlinsley]

Apparently not: #302 (comment)