Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RethinkDB support through NoBrainer #489

Closed
mbrock opened this issue Jan 7, 2015 · 3 comments
Closed

RethinkDB support through NoBrainer #489

mbrock opened this issue Jan 7, 2015 · 3 comments

Comments

@mbrock
Copy link

mbrock commented Jan 7, 2015

Hello. In order to make ActiveAdmin work with RethinkDB and the NoBrainer ORM, I'd like to add NoBrainer support to Ransack. Since @Zhomart added support for Mongoid (#407), there seems to be an extension point for new ORM adapters. Of course, I'll add specs for this, and our organization will (if all goes as planned) use this functionality in production—at least the subset touched by ActiveAdmin. I will fork the project and start working actively in the hopes of getting it working as soon as possible.

@jonatack
Copy link
Contributor

jonatack commented Jan 7, 2015

Sure, go for it! @Zhomart did help organizing the Ransack codebase to facilitate adding new adapters. The main caveat with adding RethinkDB, as with Mongoid, is that the current maintainers will likely maintain the Active Record parts of the codebase only, so keeping Mongoid and RethinkDB working will depend on the people who use them actively maintaining them :).

@jonatack jonatack closed this as completed Jan 7, 2015
@mbrock
Copy link
Author

mbrock commented Jan 7, 2015

... on second thought, we will make an attempt to get rails_admin working with NoBrainer instead, since this seems to be a simpler project. Maybe if we outgrow rails_admin, we'll get back to this, but feel free to delete this issue.

@jonatack
Copy link
Contributor

jonatack commented Jan 7, 2015

No problem. I have no opinion on RailsAdmin vs ActiveAdmin, having never used them. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants