-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use grid for surface ordering #21
Comments
So in the end the functions should return the grids instead of the vector tuples? Should this at some point become a detector description structure used in conjunction with the allocated memory for the surfaces? |
It should return: bounds, transform, grid Where the grid points to the index of the according transform. |
The overall goal is to change the |
Ok, so the binning is not configurable, but should be found automatically from say the detector dimensions, the number of surfaces, and their sizes etc., right? The range for the neighbor search should be fixed? |
In |
Hi @niermann999 - I decided to work a bit more on this, and created #31 as a first detector, this introduces some grid structure for finding the surfaces in local proximity, seems to work for a start. |
This is fixed with #31 and some onwards PRs. |
This feature is in preparation to describe full detectors with grid navigation. It will prepare this with small changes to the current tests:
Currently, in
test_surfaces.hpp
surfaces for a dummy cylinder barrel and/or endcap disc are generated using:dtuple<darray<scalar, 2>, dvector<transform3>> barrel_description
dtuple<darray<scalar, 3>, dvector<transform3>> endcap_description
In a first step, expand the two methods to include also a suitable
grid2
implementation, which is created with the correct indices of the surfaces in either barrel or endcap:Then, write a test, where you check the bin contains the best surface and with a zone check around (the grid should allow you to not only get the index of the bin, but a defined zone around).
The text was updated successfully, but these errors were encountered: