Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config types non-templated w.r.t. scalar precision #716

Closed
beomki-yeo opened this issue Apr 15, 2024 · 0 comments · Fixed by #718
Closed

Make config types non-templated w.r.t. scalar precision #716

beomki-yeo opened this issue Apr 15, 2024 · 0 comments · Fixed by #718
Labels
good first issue Good for newcomers priority: high high priority

Comments

@beomki-yeo
Copy link
Collaborator

beomki-yeo commented Apr 15, 2024 •
edited
Loading

From acts-project/traccc#540 and acts-project/traccc#542

If possible, let us make the propagation config non-templated w.r.t the scalar precision (Maybe unifying with float)

https://github.com/acts-project/detray/blob/main/core/include/detray/propagator/stepping_config.hpp
https://github.com/acts-project/detray/blob/main/core/include/detray/navigation/navigation_config.hpp
https://github.com/acts-project/detray/blob/main/core/include/detray/propagator/propagation_config.hpp
@beomki-yeo beomki-yeo added good first issue Good for newcomers priority: high high priority labels Apr 15, 2024
@beomki-yeo beomki-yeo changed the title Non-templated config type Make config types non-templated w.r.t. scalar precision Apr 15, 2024
@niermann999 niermann999 linked a pull request Apr 21, 2024 that will close this issue
ref: Allow printing of propagation config and remove templates #718
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority: high high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: Allow printing of propagation config and remove templates niermann999/detray
1 participant
@beomki-yeo