Skip to content

Commit 3d4bc82

Browse files
committed
Address SonarCloud comments.
1 parent 0acc955 commit 3d4bc82

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

examples/options/src/details/configuration_category.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
namespace traccc::opts {
1717

1818
configuration_category::configuration_category(std::string_view name)
19-
: m_name{name}, m_children{} {}
19+
: m_name{name} {}
2020

2121
configuration_category::~configuration_category() = default;
2222

examples/options/src/details/configuration_category.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,17 @@ class configuration_category final : public configuration_printable {
2929
/// Constructor
3030
explicit configuration_category(std::string_view name);
3131
/// Destructor
32-
~configuration_category() final;
32+
~configuration_category() override;
3333

3434
/// Add a single child
3535
configuration_category& add_child(child_type child);
3636

3737
private:
3838
void print_impl(std::ostream& out, std::string_view self_prefix,
3939
std::string_view child_prefix, std::size_t prefix_len,
40-
std::size_t max_key_width) const final;
40+
std::size_t max_key_width) const override;
4141

42-
std::size_t get_max_key_width_impl() const final;
42+
std::size_t get_max_key_width_impl() const override;
4343

4444
std::string m_name;
4545
children_type m_children;

examples/options/src/details/configuration_list.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ class configuration_list final : public configuration_printable {
2727
/// Constructor
2828
explicit configuration_list();
2929
/// Destructor
30-
~configuration_list() final;
30+
~configuration_list() override;
3131

3232
/// Add a single child
3333
configuration_list& add_child(child_type child);
3434

3535
private:
3636
void print_impl(std::ostream& out, std::string_view self_prefix,
3737
std::string_view child_prefix, std::size_t prefix_len,
38-
std::size_t max_key_width) const final;
38+
std::size_t max_key_width) const override;
3939

40-
std::size_t get_max_key_width_impl() const final;
40+
std::size_t get_max_key_width_impl() const override;
4141

4242
children_type m_children;
4343
}; // class configuration_list

examples/options/src/details/configuration_value.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ class configuration_value final : public configuration_printable {
2222
/// Constructor
2323
explicit configuration_value(std::string_view key, std::string_view value);
2424
/// Destructor
25-
~configuration_value() final;
25+
~configuration_value() override;
2626

2727
private:
2828
void print_impl(std::ostream& out, std::string_view self_prefix,
2929
std::string_view, std::size_t prefix_len,
30-
std::size_t max_key_width) const final;
30+
std::size_t max_key_width) const override;
3131

32-
std::size_t get_max_key_width_impl() const final;
32+
std::size_t get_max_key_width_impl() const override;
3333

3434
std::string m_key;
3535
std::string m_value;

0 commit comments

Comments
 (0)