Merge pull request #731 from beomki-yeo/kf-particle-hypo

Change the particle hypo of KF in case of charge is changed

Author: stephenswat

core/include/traccc/fitting/kalman_filter/gain_matrix_updater.hpp

@@ -121,12 +121,6 @@ struct gain_matrix_updater {
         const matrix_type<1, 1> chi2 = matrix_operator().transpose(residual) *
                                        matrix_operator().inverse(R) * residual;
 
-        // Make sure that the sign of qop does not change (This rarely happens
-        // when qop is set with a poor seed resolution)
-        assert(bound_params[e_bound_qoverp] *
-                   getter::element(filtered_vec, e_bound_qoverp, 0u) >
-               0.f);
-
         // Set the stepper parameter
         bound_params.set_vector(filtered_vec);
         bound_params.set_covariance(filtered_cov);

core/include/traccc/fitting/kalman_filter/kalman_actor.hpp

@@ -11,6 +11,7 @@
 #include "traccc/definitions/qualifiers.hpp"
 #include "traccc/edm/track_state.hpp"
 #include "traccc/fitting/kalman_filter/gain_matrix_updater.hpp"
+#include "traccc/utils/particle.hpp"
 
 // detray include(s).
 #include "detray/propagator/base_actor.hpp"
@@ -105,9 +106,16 @@ struct kalman_actor : detray::actor {
 
             // Run Kalman Gain Updater
             const auto sf = navigation.get_surface();
+
             sf.template visit_mask<gain_matrix_updater<algebra_t>>(
                 trk_state, propagation._stepping._bound_params);
 
+            // Change the charge of hypothesized particles when the sign of qop
+            // is changed (This rarely happens when qop is set with a poor seed
+            // resolution)
+            detail::correct_particle_hypothesis(stepping._ptc,
+                                                trk_state.filtered());
+
             // Update iterator
             actor_state.next();