Fixed the I/O test failures.

One failure was because of a difference in the "module link"
variable of cells. Since in the new scheme this link would
mean an index in the "global" DD object.

The other failure was however because of a genuine bug
in the spacepoint reading that I introduced while updating
the I/O code to use the new DD type.

Author: krasznaa

io/src/csv/read_spacepoints.cpp

@@ -51,13 +51,11 @@ void read_spacepoints(spacepoint_collection_types::host& spacepoints,
         // Construct the global 3D position of the spacepoint.
         const point3 pos{iohit.tx, iohit.ty, iohit.tz};
 
-        // Find the measurement associated with this spacepoint.
+        // Construct the local 3D(2D) position of the measurement.
         measurement meas;
-        for (const measurement& meas1 : measurements) {
-            if (meas1.surface_link ==
-                detray::geometry::barcode{iohit.geometry_id}) {
-                meas = meas1;
-                break;
+        for (auto const [meas_id, hit_id] : measurement_hit_ids) {
+            if (hit_id == spacepoints.size()) {
+                meas = measurements[meas_id];
             }
         }
 

tests/io/test_mapper.cpp

@@ -188,19 +188,22 @@ TEST(mappper, measurement_cell_map) {
     auto m_c_map =
         traccc::generate_measurement_cell_map(event, cells_dir, dd, resource);
 
+    // The module that the cells of event 0 belong to, happens to be this one.
+    constexpr traccc::cell::link_type module_link = 873;
+
     vecmem::vector<traccc::cell> cells0;
-    cells0.push_back({1, 0, 0.0041470062f, 0, 0});
-    cells0.push_back({0, 1, 0.00306466641f, 0, 0});
-    cells0.push_back({1, 1, 0.00868905429f, 0, 0});
-    cells0.push_back({1, 1, 0.00886478275f, 0, 0});
-    cells0.push_back({1, 2, 0.00580428448f, 0, 0});
-    cells0.push_back({2, 1, 0.0016894876f, 0, 0});
-    cells0.push_back({2, 2, 0.00199076766f, 0, 0});
+    cells0.push_back({1, 0, 0.0041470062f, 0, module_link});
+    cells0.push_back({0, 1, 0.00306466641f, 0, module_link});
+    cells0.push_back({1, 1, 0.00868905429f, 0, module_link});
+    cells0.push_back({1, 1, 0.00886478275f, 0, module_link});
+    cells0.push_back({1, 2, 0.00580428448f, 0, module_link});
+    cells0.push_back({2, 1, 0.0016894876f, 0, module_link});
+    cells0.push_back({2, 2, 0.00199076766f, 0, module_link});
 
     vecmem::vector<traccc::cell> cells1;
-    cells1.push_back({5, 5, 0.00632160669f, 0, 0});
-    cells1.push_back({5, 6, 0.00911649223f, 0, 0});
-    cells1.push_back({5, 7, 0.00518329488f, 0, 0});
+    cells1.push_back({5, 5, 0.00632160669f, 0, module_link});
+    cells1.push_back({5, 6, 0.00911649223f, 0, module_link});
+    cells1.push_back({5, 7, 0.00518329488f, 0, module_link});
 
     EXPECT_EQ(m_c_map.size(), 2);