Skip to content

Commit ed9b816

Browse files
committed
Update to detray version 66
1 parent 8d2996c commit ed9b816

File tree

12 files changed

+16
-40
lines changed

12 files changed

+16
-40
lines changed

core/include/traccc/finding/finding_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ struct finding_config {
4141
scalar_t chi2_max = 30.f;
4242

4343
/// Propagation configuration
44-
detray::propagation::config<scalar_t> propagation{};
44+
detray::propagation::config propagation{};
4545

4646
/****************************
4747
* GPU-specfic parameters

core/include/traccc/fitting/fitting_config.hpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@
1414
namespace traccc {
1515

1616
/// Configuration struct for track fitting
17-
template <typename scalar_t>
1817
struct fitting_config {
1918

2019
std::size_t n_iterations = 1;
2120

2221
/// Propagation configuration
23-
detray::propagation::config<scalar_t> propagation{};
22+
detray::propagation::config propagation{};
2423
};
2524

2625
} // namespace traccc

core/include/traccc/fitting/kalman_filter/kalman_fitter.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class kalman_fitter {
5353
using intersection_type = typename navigator_t::intersection_type;
5454

5555
/// Configuration type
56-
using config_type = fitting_config<scalar_type>;
56+
using config_type = fitting_config;
5757

5858
// Field type
5959
using bfield_type = typename stepper_t::magnetic_field_type;

examples/options/include/traccc/options/track_propagation.hpp

+2-7
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class track_propagation : public interface {
2424
/// @{
2525

2626
/// Propagation configuration object
27-
detray::propagation::config<float> config;
27+
detray::propagation::config config;
2828

2929
/// @}
3030

@@ -41,12 +41,7 @@ class track_propagation : public interface {
4141
///
4242
/// @param cfg The configuration object to fill
4343
///
44-
void setup(detray::propagation::config<float>& cfg) const;
45-
/// Set up a configuration object based on the command line options
46-
///
47-
/// @param cfg The configuration object to fill
48-
///
49-
void setup(detray::propagation::config<double>& cfg) const;
44+
void setup(detray::propagation::config& cfg) const;
5045

5146
private:
5247
/// Print the specific options of this class

examples/options/src/track_propagation.cpp

+1-24
Original file line numberDiff line numberDiff line change
@@ -57,35 +57,12 @@ void track_propagation::read(const po::variables_map&) {
5757
config.navigation.search_window = m_search_window;
5858
}
5959

60-
void track_propagation::setup(detray::propagation::config<float>& cfg) const {
60+
void track_propagation::setup(detray::propagation::config& cfg) const {
6161

6262
cfg = config;
6363
return;
6464
}
6565

66-
void track_propagation::setup(detray::propagation::config<double>& cfg) const {
67-
68-
cfg.stepping.min_stepsize = config.stepping.min_stepsize;
69-
cfg.stepping.rk_error_tol = config.stepping.rk_error_tol;
70-
cfg.stepping.step_constraint = config.stepping.step_constraint;
71-
cfg.stepping.path_limit = config.stepping.path_limit;
72-
cfg.stepping.max_rk_updates = config.stepping.max_rk_updates;
73-
cfg.stepping.use_mean_loss = config.stepping.use_mean_loss;
74-
cfg.stepping.use_eloss_gradient = config.stepping.use_eloss_gradient;
75-
cfg.stepping.use_field_gradient = config.stepping.use_field_gradient;
76-
cfg.stepping.do_covariance_transport =
77-
config.stepping.do_covariance_transport;
78-
79-
cfg.navigation.min_mask_tolerance = config.navigation.min_mask_tolerance;
80-
cfg.navigation.max_mask_tolerance = config.navigation.max_mask_tolerance;
81-
cfg.navigation.on_surface_tolerance =
82-
config.navigation.on_surface_tolerance;
83-
cfg.navigation.overstep_tolerance = config.navigation.overstep_tolerance;
84-
cfg.navigation.search_window[0] = config.navigation.search_window[0];
85-
cfg.navigation.search_window[1] = config.navigation.search_window[1];
86-
return;
87-
}
88-
8966
std::ostream& track_propagation::print_impl(std::ostream& out) const {
9067

9168
out << " Constraint step size : "

examples/simulation/simulate_toy_detector.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ int simulate(const traccc::opts::generation& generation_opts,
5656
auto field = detray::bfield::create_const_field(B);
5757

5858
// Create the toy geometry
59-
detray::toy_det_config<scalar> toy_cfg{};
59+
detray::toy_det_config toy_cfg{};
6060
toy_cfg.n_brl_layers(4u).n_edc_layers(7u);
6161
// @TODO: Increase the material budget again
6262
toy_cfg.module_mat_thickness(0.11 * detray::unit<scalar>::mm);

extern/detray/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ message( STATUS "Building Detray as part of the TRACCC project" )
1818

1919
# Declare where to get Detray from.
2020
set( TRACCC_DETRAY_SOURCE
21-
"URL;https://github.com/acts-project/detray/archive/refs/tags/v0.65.1.tar.gz;URL_MD5;fbf57a881565fa6019d79d13409b588f"
21+
"URL;https://github.com/acts-project/detray/archive/refs/tags/v0.66.0.tar.gz;URL_MD5;a4ed82b025b4e508a200925e3fb5af70"
2222
CACHE STRING "Source for Detray, when built as part of this project" )
2323

2424
mark_as_advanced( TRACCC_DETRAY_SOURCE )

simulation/include/traccc/simulation/simulator.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ struct simulator {
3333
using scalar_type = typename detector_t::scalar_type;
3434

3535
struct config {
36-
detray::propagation::config<scalar_type> propagation;
36+
detray::propagation::config propagation;
3737
};
3838

3939
using algebra_type = typename detector_t::algebra_type;

tests/common/tests/kalman_fitting_telescope_test.hpp

+1
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ class KalmanFittingTelescopeTests : public KalmanFittingTests {
8383
auto writer_cfg = detray::io::detector_writer_config{}
8484
.format(detray::io::format::json)
8585
.replace_files(true)
86+
.write_material(true)
8687
.path(std::get<0>(GetParam()));
8788
detray::io::write_detector(det, name_map, writer_cfg);
8889
}

tests/common/tests/kalman_fitting_toy_detector_test.hpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class KalmanFittingToyDetectorTests : public KalmanFittingTests {
5656
virtual void SetUp() override {
5757
vecmem::host_memory_resource host_mr;
5858

59-
detray::toy_det_config<scalar> toy_cfg{};
59+
detray::toy_det_config toy_cfg{};
6060
toy_cfg.n_brl_layers(n_barrels).n_edc_layers(n_endcaps).do_check(false);
6161

6262
// Create the toy geometry
@@ -66,6 +66,8 @@ class KalmanFittingToyDetectorTests : public KalmanFittingTests {
6666
auto writer_cfg = detray::io::detector_writer_config{}
6767
.format(detray::io::format::json)
6868
.replace_files(true)
69+
.write_grids(true)
70+
.write_material(true)
6971
.path(std::get<0>(GetParam()));
7072
detray::io::write_detector(det, name_map, writer_cfg);
7173
}

tests/common/tests/kalman_fitting_wire_chamber_test.hpp

+2
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ class KalmanFittingWireChamberTests : public KalmanFittingTests {
8282
auto writer_cfg = detray::io::detector_writer_config{}
8383
.format(detray::io::format::json)
8484
.replace_files(true)
85+
.write_grids(true)
86+
.write_material(true)
8587
.path(std::get<0>(GetParam()));
8688
detray::io::write_detector(det, name_map, writer_cfg);
8789
}

tests/cpu/test_simulation.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ GTEST_TEST(traccc_simulation, toy_detector_simulation) {
7777
auto field = detray::bfield::create_const_field(B);
7878

7979
// Create geometry
80-
detray::toy_det_config<scalar> toy_cfg{};
80+
detray::toy_det_config toy_cfg{};
8181
const auto [detector, names] = detray::build_toy_detector(host_mr, toy_cfg);
8282

8383
using geo_cxt_t = typename decltype(detector)::geometry_context;

0 commit comments

Comments
 (0)