Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🀝 Convention #73

Closed
sol-pine opened this issue Apr 14, 2023 · 0 comments
Closed

🀝 Convention #73

sol-pine opened this issue Apr 14, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sol-pine
Copy link
Member

Git Flow

  • feat/(dev name) : feature branch
  • refac/(dev name) : refactoring develop branch
  • fix/(dev name) : debugging branch
  • refactoring : refactoring branch
  • main(master) : release branch

Git Convention

Commit λ©”μ‹œμ§€

  • 기본적인 컀밋 λ©”μ‹œμ§€ κ΅¬μ‘°λŠ” 제λͺ©, λ³Έλ¬Έ 두가지 파트둜 λ‚˜λˆ„κ³ , 각 νŒŒνŠΈλŠ” ν•œ 쀄을 두어 κ΅¬λΆ„ν•œλ‹€.
  • Type, Subject
    • 제λͺ©μ€ μ΅œλŒ€ 50κΈ€μžκ°€ λ„˜μ§€ μ•Šλ„λ‘ ν•˜κ³  νŠΉμˆ˜κΈ°ν˜ΈλŠ” μ‚¬μš©ν•˜μ§€ μ•ŠλŠ”λ‹€.
    • 영문으둜 ν‘œκΈ°ν•˜λŠ” 경우 이λͺ¨μ§€λ₯Ό κ°€μž₯ μ•žμ— 두고 λ©”μ‹œμ§€λ₯Ό μ†Œλ¬Έμžλ‘œ ν‘œκΈ°ν•œλ‹€.
    • 제λͺ©μ€Β κ°œμ‘°μ‹ ꡬ문(μ™„μ „ν•œ μ„œμˆ ν˜• λ¬Έμž₯이 μ•„λ‹ˆλΌ, κ°„κ²°ν•˜κ³  μš”μ μ μΈ μ„œμˆ μ„ 의미)으둜 μž‘μ„±ν•œλ‹€.
    • fix. 버그 μˆ˜μ •
  • Body (option)
    • 본문은 컀밋 상세 이유λ₯Ό μž‘μ„±ν•œλ‹€.
    • ν•œ 쀄 λ‹Ή 72자 λ‚΄λ‘œ μž‘μ„±ν•œλ‹€.
    • Titleκ³Ό Bodyμ‚¬μ΄μ—λŠ” 곡백 ν•œ 쀄을 두고 μž‘μ„±ν•œλ‹€.

Git κ·œμΉ™

  • Git Convention은 λ°˜λ“œμ‹œ μˆ™μ§€ν•˜κ³  μ§€μΌœμ£Όμ„Έμš”.
  • μ•ˆμ“°λŠ” μ½”λ“œλ“€(μ½˜μ†”, 주석)은 μŒ“μ•„λ‘μ§€ 말고 μ§€μ›Œμ£Όμ„Έμš”.
  • Pull β†’ Commit β†’ Push μˆœμ„œλ‘œ μž‘μ—…ν•΄μ£Όμ„Έμš”.
  • push μ „ μ—λŸ¬κ°€ μ•ˆλ‚˜λŠ” 지 λ¨Όμ € ν™•μΈν•˜κ³  push ν›„μ—λŠ” PR ν•©λ‹ˆλ‹€.
  • PR을 거쳐 λͺ¨λ“  νŒ€μ›λ“€μ΄ 승인 ν›„, merge ν•©λ‹ˆλ‹€. conflict 해결은 λͺ¨λ“  νŒ€μ›μ΄ ν•¨κ»˜ μ°Έμ—¬ν•΄μš”!

Commit Message Prefix

  • feat.Β κΈ°λŠ₯ 및 CSS μΆ”κ°€, μ‚­μ œ, λ³€κ²½ -Β μ½”λ“œ μˆ˜μ • λ°œμƒ μ‹œ
  • fix. 버그 μˆ˜μ • -Β μ½”λ“œ μˆ˜μ • λ°œμƒ μ‹œ, 디버깅 μ‹œ
  • docs. 물리적인 파일 μΆ”κ°€, 파일λͺ… μ‚­μ œ, 파일λͺ… λ³€κ²½ -Β κΈ°λ³Έ μ½”λ“œ μž‘μ„±ν•˜κ³  컀밋
  • refactor.Β μ½”λ“œ λ¦¬νŒ©ν† λ§ ex) renaming a variable -Β μ½”λ“œ μˆ˜μ • λ°œμƒ μ‹œ
  • chore.Β νŒ¨ν‚€μ§€, 라이브러리 μ„€μΉ˜ -Β μ½”λ“œ μˆ˜μ • μ—†μŒ

Convention

  • 폴더λͺ… : camelCase
  • 파일λͺ… : PascalCase(tsx), camelCase(κ·Έ μ™Έ)
  • μ»΄ν¬λ„ŒνŠΈλͺ… : PascalCase
  • λ³€μˆ˜λͺ… : camelCase
  • μ „μ—­ μƒμˆ˜λͺ… : λŒ€λ¬Έμž snake_case
  • scss λ³€μˆ˜λͺ… : snake_case
  • className: snake_case
  • ν•¨μˆ˜λͺ… : λ™μ‚¬λ‘œ μ‹œμž‘
  • μ»€μŠ€ν…€ν›… : use둜 μ‹œμž‘

폴더 ꡬ쑰

γ„΄ πŸ“ components
   γ„΄ πŸ“ common // 2개 이상 νŽ˜μ΄μ§€μ—μ„œ μž¬μ‚¬μš©λ˜λŠ” μ»΄ν¬λ„ŒνŠΈ
   γ„΄ πŸ“ main // μ‚¬μš©λ˜λŠ” νŽ˜μ΄μ§€λ‘œ ꡬ뢄
      γ„΄ πŸ“„ MainBanner.tsx
      γ„΄ πŸ“„ MainProducts.tsx
γ„΄ πŸ“ elements // 곡톡 μ—˜λ¦¬λ¨ΌνŠΈ
γ„΄ πŸ“ pages // νŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ
γ„΄ πŸ“ constants // μ „μ—­ μƒμˆ˜
γ„΄ πŸ“ hooks // μ»€μŠ€ν…€ ν›…
γ„΄ πŸ“ query // 쿼리 ν›…
γ„΄ πŸ“ redux // redux
γ„΄ πŸ“ shared 
   γ„΄ πŸ“ api
   γ„΄ πŸ“ types // μ „μ—­ νƒ€μž… 
   γ„΄ πŸ“ style // GlobalStyle,theme,style.d.ts
   γ„΄ πŸ“ utils // μœ ν‹Έ ν•¨μˆ˜
γ„΄ πŸ“ style // μ»΄ν¬λ„ŒνŠΈ style
@sol-pine sol-pine added the documentation Improvements or additions to documentation label Apr 14, 2023
@sol-pine sol-pine self-assigned this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant