Colours not working in Windows

[RubyBit]

Describe the bug
In a Windows command line terminal, colours are not correctly displayed, instead random letters and symbols are (which I assume is the supposed syntax for the colour). This seems to be a problem with the colored crate but I would suggest to at least when using the None option for the colours to add no such syntax at all and just the spinner with the text (looking on how its done in the source code).

To Reproduce
Steps to reproduce the behavior:

1. Create any spinner with any color (includine the None option)
2. Open the created binary on a windows command line terminal (not the new Windows Terminal)
3. See error

Expected behavior
A colour should be displayed (again, probably an error with the colored crate)

Desktop:

• OS: Windows

Additional info
This might not be able to be fixed by you (see above with the colored crate) but I like your crate so the suggested fix would be nice, so I can use the spinners without the colours :)

[RubyBit]

This might be interesting (was looking through the colored crate issues), seems to include a possible fix for at least windows 10 with the control::set_virtual_terminal function.
colored-rs/colored#59

[ad4mx]

Hi, I'm going to fix it as soon as I can.

[ad4mx]

Hi @RubyBit, could you please run #7's branch's examples locally to tell me if anything changed? I want to see if I still can use the colored crate or if I should switch.

[RubyBit]

I tested it and normal (without colour) mode works nicely but the problem persists with coloured text. Testing it with the set_virtual_terminal function, the colours as well as symbols are correctly displayed!

I also want to mention as I failed to mention this in the bug report, this happens when a console is allocated(through AllocConsole) to my process (which doesnt have one), and the white colour could not be displayed for some reason (I tested with the white colour in a normal command prompt project and it worked fine). Nevertheless, set_virtual_terminal adds full functionality for all colours and symbols at both cases.

[ad4mx]

I'm happy that it works now. I reckon I could include set_virtual_terminal in the code as an OS specific thing so the user doesn't have to bother with it?

[RubyBit]

Yes that would be nice and I believe easily implemented with a conditional statement using the cfg! macro. I think it is quite important here as it allows for not only colours but every symbol to be properly displayed in a windows command line prompt (thus the crate works as intended in windows).

[ad4mx]

Right, should be added to the branch now. Could you just verify for the last time that it works without explicitly setting the virtual terminal like before?

[ad4mx]

After that, it should be ready for a merge.

[RubyBit]

Everything seems to work but I am not sure if the branch will compile in other OSes as you use a conditional compiled function in a function which is compiled on all OSes ( I have added a comment on the code with a potential fix)

[ad4mx]

Right, That seems to be an issue. Where did you add your comment? I can't see it anywhere.

[RubyBit]

If you go to the pull request, it is there. I was just saying to immediately set control::set_virtual_terminal(true) if the cfg! conditional is true without referring to the conditional function (thus removing the build error)

[ad4mx]

Setting it directly in the cfg! conditional doesn't actually seem to do anything since the set_virtual_terminal function is target_os limited by default so our build environment (ubuntu) won't be able to find it.

[ad4mx]

To me, it looks like unfortunately the user will have to set it themselves. I could, however include a note in the readme so users won't get confused.

[RubyBit]

Yes that should work and be quite straight forward.