-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom coverage threshold for new files #28
Comments
Yes, I think we can add it if we want to set customly. But I am not sure if we can just use comments to ignore the lines we don't want to cover. |
Yes, but that's still some extra work to figure out where to put those comments and test if they work. Sometimes we have to add quite a few comments which makes the code harder to read. A global custom threshold works by default. |
Make sense. Let me create a ticket to follow up it |
Thank you! |
Apologies for the delay in addressing this ticket here. I haven't had the opportunity to follow up on it yet. I can attend to it once I've completed a few higher-priority tasks currently on my plate. If someone else is available to assist in the meantime, that would be grateful. |
@xueyan-lu Have we considered supporting custom coverage threshold for new files? Currently it's either 100% or disabled, for internal projects like CMSUI, it's not always necessary to require 100% coverage for new files. But disabling it means there won't be a check for coverage at all. So I'm wondering if we can support setting a custom threshold just for new files.
The text was updated successfully, but these errors were encountered: