Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Node.js #544

Closed
anonrig opened this issue Oct 22, 2023 · 1 comment · Fixed by #545
Closed

Build fails on Node.js #544

anonrig opened this issue Oct 22, 2023 · 1 comment · Fixed by #545

Comments

@anonrig
Copy link
Member

anonrig commented Oct 22, 2023

Full log: https://ci.nodejs.org/job/node-test-commit-linux-containered/40031/nodes=ubi81_sharedlibs_openssl111fips_x64/console

00:00:38.632 In file included from ../src/encoding_binding.cc:2:
00:00:38.632 ../deps/ada/ada.h:1509:3: error: inline function 'virtual size_t ada::url_base::parse_port(std::string_view, bool)' used but never defined [-Werror]
00:00:38.632    parse_port(std::string_view view, bool check_trailing_content) noexcept = 0;
00:00:38.632    ^~~~~~~~~~
00:00:38.632 cc1plus: all warnings being treated as errors
00:00:38.633 make[2]: *** [libnode.target.mk:422: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode/src/encoding_binding.o] Error 1
00:00:38.634 make[2]: *** Waiting for unfinished jobs....
00:00:40.164 In file included from ../src/node_url.h:7,
00:00:40.164                  from ../src/node_api.cc:13:
00:00:40.164 ../deps/ada/ada.h:1509:3: error: inline function 'virtual size_t ada::url_base::parse_port(std::string_view, bool)' used but never defined [-Werror]
00:00:40.164    parse_port(std::string_view view, bool check_trailing_content) noexcept = 0;
00:00:40.164    ^~~~~~~~~~
00:00:40.164 cc1plus: all warnings being treated as errors
00:00:40.167 make[2]: *** [libnode.target.mk:422: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/libnode/src/node_api.o] Error 1
00:00:42.676 In file included from ../src/cares_wrap.cc:23:
00:00:42.676 ../deps/ada/ada.h:1509:3: error: inline function 'virtual size_t ada::url_base::parse_port(std::string_view, bool)' used but never defined [-Werror]
00:00:42.676    parse_port(std::string_view view, bool check_trailing_content) noexcept = 0;
00:00:42.676    ^~~~~~~~~~
00:00:42.676 cc1plus: all warnings being treated as errors
@anonrig
Copy link
Member Author

anonrig commented Oct 22, 2023

Ref: nodejs/node#50323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant