Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zillions of errors when used on incorrect architecture #8

Open
bperrybap opened this issue May 6, 2017 · 2 comments
Open

Zillions of errors when used on incorrect architecture #8

bperrybap opened this issue May 6, 2017 · 2 comments

Comments

@bperrybap
Copy link

If a user includes TinyWireM.h in a sketch and builds for say an Uno board, they will get tons of errors.
They can easily be confused and not recognize the issue. (I have seen this first hand)
The current library.properties says the library works on any architecture.
The properties files should indicate that it is AVR only.
But even specifying that the library architecture is AVR only does not fully solve the issue.
So to fully remedy the issue, TinyWireM.h should also use conditionals to explicitly check the processor type being used and crash the compile with a meaningful error message when attempting to use it on an unsupported processor.

Even better would be to work with the Attiny core maintainer and get this library into to actual core so that it is only available when that tiny core type is being used.

@ladyada
Copy link
Member

ladyada commented May 6, 2017

yes, it has been added to the adafruit arduino boards package as Wire, so you can just use wire :)

@bperrybap
Copy link
Author

Nice. But I see that the Wire library in the adafruit board package includes the TinyWireM code which also suffers from the same bug reported in issue #7
I'll go file a bug over there for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants