Fixed #116: Postbox is broken

Author: adam-p

src/common/common-logic.js

@@ -185,14 +185,16 @@ function findClosestSendButton(elem) {
   // boundaries and sometimes we won't.
 
   var sendButton = null;
-  while (elem.parentElement) {
-    sendButton = elem.parentElement.querySelector('[role="button"][tabindex="1"]');
+  // The `elem.parentNode.querySelector` check is to make sure we stop if we
+  // hit a parent node type that can't query.
+  while (elem.parentNode && elem.parentNode.querySelector) {
+    sendButton = elem.parentNode.querySelector('[role="button"][tabindex="1"]');
     if (sendButton) {
       debugLog('findClosestSendButton', 'found');
       return sendButton;
     }
 
-    elem = elem.parentElement;
+    elem = elem.parentNode;
   }
 
   // If this appears to be in an iframe, make a recursive call.
@@ -278,7 +280,7 @@ function setupForgotToRenderInterceptors(composeElem, MdhHtmlToText, marked, pre
     var ourTarget =
       (event.target === composeElem) ||
       (event.target instanceof composeElem.ownerDocument.defaultView.HTMLHtmlElement &&
-       event.target === composeElem.parentElement);
+       event.target === composeElem.parentNode);
 
     if (ourTarget &&
         (event.metaKey || event.ctrlKey) && event.keyCode === ENTER_KEYCODE &&
@@ -290,10 +292,10 @@ function setupForgotToRenderInterceptors(composeElem, MdhHtmlToText, marked, pre
     debugLog('setupForgotToRenderInterceptors', 'sendHotkeyKeydownListener', 'skipping undesired event', event.target);
   };
 
-  composeSendButton.parentElement.addEventListener('keydown', composeSendButtonKeyListener, true);
-  composeSendButton.parentElement.addEventListener('keyup', composeSendButtonKeyListener, true);
-  composeSendButton.parentElement.addEventListener('click', composeSendButtonClickListener, true);
-  composeElem.parentElement.addEventListener('keydown', sendHotkeyKeydownListener, true);
+  composeSendButton.parentNode.addEventListener('keydown', composeSendButtonKeyListener, true);
+  composeSendButton.parentNode.addEventListener('keyup', composeSendButtonKeyListener, true);
+  composeSendButton.parentNode.addEventListener('click', composeSendButtonClickListener, true);
+  composeElem.parentNode.addEventListener('keydown', sendHotkeyKeydownListener, true);
 }
 
 // Returns true if `text` looks like raw Markdown, false otherwise.

src/common/markdown-here.js

@@ -224,7 +224,7 @@ function makeStylesExplicit(wrapperElem, css) {
 
     // We're starting our search one level above the wrapper, which means we
     // might match stuff outside of our wrapper. We'll have to double-check below.
-    selectorMatches = wrapperElem.parentElement.querySelectorAll(rule.selectorText);
+    selectorMatches = wrapperElem.parentNode.querySelectorAll(rule.selectorText);
 
     for (j = 0; j < selectorMatches.length; j++) {
       elem = selectorMatches[j];
@@ -236,12 +236,14 @@ function makeStylesExplicit(wrapperElem, css) {
       }
 
       // Make sure the selector match isn't inside an exclusion block.
-      while (elem) {
+      // The check for `elem.classList` stop us if we hit a non-element node
+      // while going up through the parents.
+      while (elem && (typeof(elem.classList) !== 'undefined')) {
         if (elem.classList.contains('markdown-here-exclude')) {
           elem = 'excluded';
           break;
         }
-        elem = elem.parentElement;
+        elem = elem.parentNode;
       }
       if (elem === 'excluded') {
         // Don't style this element.
@@ -272,13 +274,13 @@ function hasParentElementOfTagName(element, tagName) {
 
   tagName = tagName.toUpperCase();
 
-  parent = element.parentElement;
+  parent = element.parentNode;
   while (parent) {
     if (parent.nodeName === tagName) {
       return true;
     }
 
-    parent = parent.parentElement;
+    parent = parent.parentNode;
   }
 
   return false;
@@ -314,7 +316,7 @@ function findMarkdownHereWrapper(focusedElem) {
       break;
     }
 
-    wrapper = wrapper.parentElement;
+    wrapper = wrapper.parentNode;
   }
 
   return wrapper;

src/common/options-store.js

@@ -479,7 +479,7 @@ this.OptionsStore._fillDefaults = function(prefsObj, callback) {
     // Only take action if the key doesn't already have a value set.
     if (typeof(prefsObj[key]) === 'undefined') {
       if (that.defaults[key].hasOwnProperty('__defaultFromFile__')) {
-        var xhr = new XMLHttpRequest();
+        var xhr = new Utils.global.XMLHttpRequest();
 
         if (that.defaults[key]['__mimeType__']) {
           xhr.overrideMimeType(that.defaults[key]['__mimeType__']);

src/common/utils.js

@@ -131,6 +131,21 @@ function isElementinDocument(element) {
 }
 
 
+// From: http://stackoverflow.com/a/3819589/729729
+// Postbox doesn't support `node.outerHTML`.
+function outerHTML(node, doc) {
+  // if IE, Chrome take the internal method otherwise build one
+  return node.outerHTML || (
+    function(n){
+        var div = doc.createElement('div'), h;
+        div.appendChild(n.cloneNode(true));
+        h = div.innerHTML;
+        div = null;
+        return h;
+    })(node);
+}
+
+
 // An approximate equivalent to outerHTML for document fragments.
 function getDocumentFragmentHTML(docFrag) {
   var html = '', i;
@@ -140,7 +155,7 @@ function getDocumentFragmentHTML(docFrag) {
       html += node.nodeValue;
     }
     else { // going to assume ELEMENT_NODE
-      html += node.outerHTML;
+      html += outerHTML(node, docFrag.ownerDocument);
     }
   }
 
@@ -150,7 +165,7 @@ function getDocumentFragmentHTML(docFrag) {
 
 function isElementDescendant(parent, descendant) {
   var ancestor = descendant;
-  while (!!(ancestor = ancestor.parentElement)) {
+  while (!!(ancestor = ancestor.parentNode)) {
     if (ancestor === parent) {
       return true;
     }