Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and Tests for PolarsMixin #56

Merged
merged 19 commits into from
Aug 13, 2024
Merged

Fixes and Tests for PolarsMixin #56

merged 19 commits into from
Aug 13, 2024

Conversation

adamamer20
Copy link
Collaborator

@adamamer20 adamamer20 commented Aug 12, 2024 •
edited
Loading

This PR fixes the logic of many PolarsMixin methods and adds tests for all methods.

adamamer20 added 10 commits August 4, 2024 12:51
@adamamer20 adamamer20 linked an issue Aug 12, 2024 that may be closed by this pull request
Tests for PolarsMixin #53
Closed
@adamamer20 adamamer20 marked this pull request as draft August 12, 2024 12:51
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.45205% with 15 lines in your changes missing coverage. Please review.

Files Patch % Lines
mesa_frames/concrete/polars/mixin.py 79.45% 15 Missing ⚠️
Files Coverage Δ
mesa_frames/concrete/polars/mixin.py 86.85% <79.45%> (+60.57%) ⬆️

@adamamer20 adamamer20 marked this pull request as ready for review August 12, 2024 13:23
@adamamer20 adamamer20 added the enhancement Improvements to existing features or performance. label Aug 12, 2024
@adamamer20 adamamer20 added this to the 0.1.0 Alpha Release milestone Aug 12, 2024
@adamamer20 adamamer20 self-assigned this Aug 12, 2024
@adamamer20 adamamer20 marked this pull request as draft August 12, 2024 14:06
@adamamer20 adamamer20 marked this pull request as ready for review August 13, 2024 15:20
@adamamer20 adamamer20 requested a review from rht August 13, 2024 15:21
@rht
Copy link
Contributor

rht commented Aug 13, 2024

Did you use polars-upgrade for any of the changes in this PR?

@adamamer20
Copy link
Collaborator Author

Did you use polars-upgrade for any of the changes in this PR?

No, just something for the future. It's pretty new, so I have to assess stability.

@rht
Copy link
Contributor

rht commented Aug 13, 2024

I'm not familiar with Polars API at the moment, so I approve the PR so as not to block you.

@adamamer20
Copy link
Collaborator Author

I'm not familiar with Polars API at the moment, so I approve the PR so as not to block you.

No problem, we can always evaluate performance later. I'll just add tests for missing lines.

@adamamer20 adamamer20 merged commit f3240ca into main Aug 13, 2024
6 checks passed
@adamamer20 adamamer20 deleted the 53-tests-for-polarsmixin branch August 13, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht approved these changes

Assignees

@adamamer20 adamamer20

Labels
enhancement Improvements to existing features or performance.
Projects
None yet
Milestone
0.1.0 Alpha Release
Development

Successfully merging this pull request may close these issues.

Tests for PolarsMixin
2 participants
@adamamer20 @rht