Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Mono repo? #25

Open
Rayraegah opened this issue Nov 11, 2017 · 2 comments
Open

Question: Mono repo? #25

Rayraegah opened this issue Nov 11, 2017 · 2 comments

Comments

@Rayraegah
Copy link

Will you consider turning Sur+ into a mono repo with something like Lerna?

Happy to help.

@adamhaile
Copy link
Owner

Hi Ray --
Sorry for the slow reply. Yeah, I would find something like that useful. It would have helped a lot, I think, when I was getting coordinated beta releases of the various packages out. But I don't really know what best practices are here, and I also don't know how big to make the scope of the mono repo. I think I'd leave S out of it, as it has utility beyond surplus, but again I don't have experience in how inclusive a mono repo should be. At a minimum, surplus plus the various build tools (surplus-loader, etc) makes sense. Any advice?
-- Adam

@Rayraegah
Copy link
Author

Yes. Its more about modularity and convenience.

Let me see if i can make it simple for you: if the project is called Surplus then the mono repo has:

/packages/surplus
/packages/babel-preset-surplus
/packages/surplus-*

There are no best practices afaik, but what we usually do is keep dependencies together in /packages/ dir. For packages you don't intent to publish keep them in /packages/ dir but mark them as private: true in package.json

In the case of S, you could simply have S as a git submodule inside /packages/ (I do this a lot, although its shunned upon)

Here are a few mono repo samples
https://github.com/egoist/poi (pure)
https://github.com/vuejs/vue (impure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants