Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS support #168

Open
slonopotamus opened this issue May 20, 2021 · 4 comments
Open

Add MacOS support #168

slonopotamus opened this issue May 20, 2021 · 4 comments
Labels
awaiting-upstream Awaiting bugfixes or functionality from upstream dependencies enhancement New feature or request

Comments

@slonopotamus
Copy link
Collaborator

There exists Docker-OSX project that we could use as a base for MacOS builds.

@slonopotamus slonopotamus added the enhancement New feature or request label May 20, 2021
@adamrehn
Copy link
Owner

Having a read through the Docker-OSX documentation, it definitely seems like it's a useful solution for running macOS VM images inside Linux containers, but I'm not sure how useful it is for building the VM images? It doesn't look like it supports building Dockerfiles, and the examples all appear to be based around spinning up a container and then running commands to modify the state of the mutable VM image. Unless I'm misunderstanding something, it seems to me like the best approach would be to build macOS VM images with a mature image builder tool like HashiCorp Packer and then wrap them in Docker-OSX container images as a post-processing step. The end result would still be a container image, and therefore still in scope for the ue4-docker project.

@slonopotamus what are your thoughts? Are there any details that I've missed or misinterpreted?

@slonopotamus
Copy link
Collaborator Author

slonopotamus commented May 21, 2021

Well, technically building a container is just running a container and then commiting the result, so building isn't very much different from running.

I'm not sure if Docker-OSX will actually end up usable for this task or we would instead go a completely different route. Think of it as just some input data for investigation of possible ways.

@adamrehn
Copy link
Owner

Well, technically building a container is just running a container and then commiting the result, so building isn't very much different from running.

Indeed, my thinking is mostly around how robust the tooling is around running multiple commands and capturing the result. Without Dockerfile support, Docker-OSX looks like you'd need to write your own scripting to do this, whereas tools like Packer already provide a well-tested implementation of this functionality.

I'm not sure if Docker-OSX will actually end up usable for this task or we would instead go a completely different route. Think of it as just some input data for investigation.

Understood. It's certainly interesting to see projects like Docker-OSX providing a container interface for macOS systems in lieu of true container support.

@adamrehn
Copy link
Owner

I've had some additional thoughts about this, which I've documented here: containerd/containerd#5525

@slonopotamus slonopotamus added the awaiting-upstream Awaiting bugfixes or functionality from upstream dependencies label Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream Awaiting bugfixes or functionality from upstream dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants