Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more than 8 data bytes #3

Open
morcibacsi opened this issue Nov 27, 2020 · 2 comments
Open

Display more than 8 data bytes #3

morcibacsi opened this issue Nov 27, 2020 · 2 comments

Comments

@morcibacsi
Copy link

Not really an issue but a suggestion. It would be awesome to have more than 8 places for the data bytes. I know it was mainly written with CAN bus in mind which has a max length of 8 data bytes, however there are some protocols which supports more than that. I spent a lot of time reverse engineering the VAN bus used in Peugeot cars where a message could contain up to 30 bytes of data. If you would extend the interface, this could become an universal sniffing tool.

Nice project, and videos by the way ;)

@adamtheone
Copy link
Owner

Thanks for the suggestion, it makes sense.
It should not be a problem, but would require some ground work, since the max 8 bytes is hardcoded in some places in the code too. I'll keep this idea in mind, and we'll see whether this is a useful feature for others too.

@adamtheone
Copy link
Owner

Thanks for the PR, I'll review it in the upcoming days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants