Skip to content
This repository has been archived by the owner on Feb 26, 2018. It is now read-only.

XSS Vulnerabilities #48

Closed
EAnushan opened this issue May 20, 2015 · 1 comment
Closed

XSS Vulnerabilities #48

EAnushan opened this issue May 20, 2015 · 1 comment

Comments

@EAnushan
Copy link

I believe the textarea input is vulnerable to xss. It uses $value to between the textarea tags. We haven't escaped this value. We need to be using htmlentities($output, ENT_QUOTES, 'UTF-8') to escape any user provided output, as none of it should be able to break the html.

There are other locations, other than textarea where we should be doing this escaping. Anywhere we accept user/developer input and render it should be escaped.

@adamwathan
Copy link
Owner

Thanks for the heads up, feel free to submit a PR if you'd like, otherwise I'll try and get to it today! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants