Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if I need new UUIDs for scraps when cloning a page #1688

Closed
1 task
adamwulf opened this issue Sep 17, 2016 · 1 comment
Closed
1 task

Check if I need new UUIDs for scraps when cloning a page #1688

adamwulf opened this issue Sep 17, 2016 · 1 comment
Milestone

Comments

@adamwulf
Copy link
Owner

adamwulf commented Sep 17, 2016

Related to #501

I do change the scrap UUIDs when sending a page over cloud kit, but I don't change the UUIDs when I clone scraps to/from other pages or the sidebar.

That means that I /do/ need to change the scrap UUID when I clone a page. otherwise I could clone a page, and then move that 2nd page's scraps back to the first page and have a scrap UUID conflict.

  • abstract out the UUID update code from MMExportablePaperView.m so that I can change a scraps UUID from either sending over cloudkit or when cloning a page without duplicating code.
@adamwulf adamwulf added this to the v2.2.0 milestone Sep 17, 2016
@adamwulf
Copy link
Owner Author

I take all of that back. It actually clones the scrap to the new page when adding from the sidebar, so it doesn't matter if two pages have scraps with the exact same UUID after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant